WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] IRQ Cleanup: rename nr_ioapic_registers to nr_i

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] IRQ Cleanup: rename nr_ioapic_registers to nr_ioapic_entries
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Mon, 26 Sep 2011 09:27:27 -0700
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>
Delivery-date: Mon, 26 Sep 2011 09:28:12 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=0aAApGCDv6tuZuITThF2XYSFAT/vFDq6u+dQSEHSZ8Q=; b=G4MofnA+vEkrz/fy7dGtJR1/SEG8i8Oz2PHJUz3WKQMdOS2TWezCGc1KbASdbXiffo +YEVSfQ2o+2D8knRLkba9sfqtaM9uDetb7xiE/BL12aM7K4eGKaMGWVkbixjna3110rt cIQ9hWaN4+pPpybstLAe8bC+0gF4E4LXUz4SY=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110926154514.GB17331@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acx8aS3gi1qJ/PosS0SBfIegJwl7Gg==
Thread-topic: [Xen-devel] [PATCH] IRQ Cleanup: rename nr_ioapic_registers to nr_ioapic_entries
User-agent: Microsoft-Entourage/12.30.0.110427
On 26/09/2011 08:45, "Konrad Rzeszutek Wilk" <konrad.wilk@xxxxxxxxxx> wrote:

>> I guess it depends on whether you consider that we should stay in line
>> with Linux or not.  While the code did start in Linux, it has diverged
> 
> Stay. Intel does a lot of work of "lift from Linux" and drop in Xen
> code. There is similarity.

You might also say it gives a false sense of similarity. Andrew's now having
to go fix the per-cpu vector stuff for example. It got dropped in; it was
complex and opaque; it doesn't really work properly yet. I'd prefer the
people doing the porting to have to think about each line a bit more.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel