Re: [Xen-devel] [PATCH 6 of 6] libxl: use hotplug-status to synchronize the destruction of block devices

[Roger Pau Monné <roger.pau@xxxxxxxxxxxxx>]

> I wonder if we can remove the hard coding of the VBD special case
> somehow? For example an ops struct in an array mapping DEVICE_* to
>        int (*watch_for_disconnect)(relevant arguments)
>        int (*has_disconnected)(relevant arguments)
> which would have two implementations, one checking state and the other
> hotplug-status.

This would certainly make the code much cleaner and easy to understand.

> That leaves the change in wait_for_dev_destroy which unfortunately
> doesn't have the context to do much else than what you've done. Perhaps
> that's ok as is until I can finish of the patch series I have which
> fixes that aspect. I suppose a function pointer could be encoded in the
> XS_WATCH_TOKEN and sscanf'd back out again...

This patch it's the best way I came up with to fix the issue without
modifying the structure of the code much. If you have any other ideas,
I'm glad to try to implement them. Anyway, I will try to implement
something similar to what you exposed above and post a patch.

Regards, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel