[Xen-devel] Re: 4.0/4.1 requests - IO-APIC EOI [RFC]

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.09.11 at 15:18, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> --- SNIP ---
> 
> Attached is my first attempt at expanding the EOI to work on older
> IO-APICs.  It has not undergone any significant testing yet.
> 
> Does this look suitable?

It looks correct, but I'd prefer not having two io_apic_eoi_*() functions:
Namely in the "normal" __eoi_IO_APIC_irq() case you have pin *and*
vector readily available, and hence there is no need to look up anything.
So perhaps a better option would be to pass both pin and vector to
io_apic_eoi() (using e.g. -1 to identify the "unknown-needs-lookup"
case).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel