[Xen-devel] Re: [PATCH] libxl: fix double free at get_all_assign

To:	Marek Marczykowski <marmarek@xxxxxxxxxxxx>
Subject:	[Xen-devel] Re: [PATCH] libxl: fix double free at get_all_assigned_devices
From:	Marek Marczykowski <marmarek@xxxxxxxxxxxx>
Date:	Mon, 05 Sep 2011 00:05:36 +0200
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Sun, 04 Sep 2011 15:07:30 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<4683409fac3d4fef836c.1315173032@devel14>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<4683409fac3d4fef836c.1315173032@devel14>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Lightning/1.0b3pre Thunderbird/3.1.11

On 04.09.2011 23:50, Marek Marczykowski wrote:
> # HG changeset patch
> # User Marek Marczykowski <marmarek@xxxxxxxxxxxx>
> # Date 1315172996 -7200
> # Node ID 4683409fac3d4fef836ce78f01f12b31f5f9e12a
> # Parent  6239209bb560b4931d4d97456c82c1a5ca4bd10a
> libxl: fix double free at get_all_assigned_devices
> 
> Do not free() list manually - it will be freed by libxl__free_all.
> 
> Signed-off-by: Marek Marczykowski <marmarek@xxxxxxxxxxxx>

Ah, it is for xen-4.1. In unstable seems to be ok.

> diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
> --- a/tools/libxl/libxl_pci.c
> +++ b/tools/libxl/libxl_pci.c
> @@ -469,7 +469,6 @@ static int get_all_assigned_devices(libx
>      }
>  
>      if ( 0 == *num ) {
> -        free(pcidevs);
>          pcidevs = NULL;
>      }else{
>          *list = pcidevs;
> 
> 


-- 
Pozdrawiam / Best Regards,
Marek Marczykowski         | RLU #390519
marmarek at mimuw edu pl   | xmpp:marmarek at staszic waw pl

smime.p7s
Description: S/MIME Cryptographic Signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] Re: [PATCH] libxl: fix double free at get_all_assigned_devic