| 
         
xen-devel
[Xen-devel] [PATCH 09/13] x86/pvticketlocks: we only need to kick	if the
 
| 
To:  | 
"H. Peter Anvin" <hpa@xxxxxxxxx> | 
 
| 
Subject:  | 
[Xen-devel] [PATCH 09/13] x86/pvticketlocks: we only need to kick	if there's waiters | 
 
| 
From:  | 
Jeremy Fitzhardinge <jeremy@xxxxxxxx> | 
 
| 
Date:  | 
Thu,  1 Sep 2011 17:55:02 -0700 | 
 
| 
Cc:  | 
Marcelo Tosatti <mtosatti@xxxxxxxxxx>, Nick Piggin <npiggin@xxxxxxxxx>,	KVM <kvm@xxxxxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>,	the arch/x86 maintainers <x86@xxxxxxxxxx>,	Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>,	Andi Kleen <andi@xxxxxxxxxxxxxx>, Avi Kivity <avi@xxxxxxxxxx>,	Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>,	Ingo Molnar <mingo@xxxxxxx>,	Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>,	Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx> | 
 
| 
Delivery-date:  | 
Thu, 01 Sep 2011 18:09:51 -0700 | 
 
| 
Envelope-to:  | 
www-data@xxxxxxxxxxxxxxxxxxx | 
 
| 
In-reply-to:  | 
<cover.1314922370.git.jeremy.fitzhardinge@xxxxxxxxxx> | 
 
| 
In-reply-to:  | 
<cover.1314922370.git.jeremy.fitzhardinge@xxxxxxxxxx> | 
 
| 
List-help:  | 
<mailto:xen-devel-request@lists.xensource.com?subject=help> | 
 
| 
List-id:  | 
Xen developer discussion <xen-devel.lists.xensource.com> | 
 
| 
List-post:  | 
<mailto:xen-devel@lists.xensource.com> | 
 
| 
List-subscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe> | 
 
| 
List-unsubscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> | 
 
| 
References:  | 
<cover.1314922370.git.jeremy.fitzhardinge@xxxxxxxxxx> | 
 
| 
References:  | 
<cover.1314922370.git.jeremy.fitzhardinge@xxxxxxxxxx> | 
 
| 
Sender:  | 
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx | 
 
 
 
From: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
If we're releasing the lock into an uncontended state, there's nobody
waiting on it, so there's no need to kick anyone.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
---
 arch/x86/kernel/paravirt-spinlocks.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/paravirt-spinlocks.c 
b/arch/x86/kernel/paravirt-spinlocks.c
index 21b6986..71b8557 100644
--- a/arch/x86/kernel/paravirt-spinlocks.c
+++ b/arch/x86/kernel/paravirt-spinlocks.c
@@ -47,8 +47,7 @@ void __ticket_unlock_release_slowpath(struct arch_spinlock 
*lock)
                    old.head_tail, new.head_tail) != old.head_tail) {
                /* still people waiting */
                __ticket_unlock_release(lock);
+               __ticket_unlock_kick(lock, new.tickets.head);
        }
-
-       __ticket_unlock_kick(lock, new.tickets.head);
 }
 EXPORT_SYMBOL(__ticket_unlock_release_slowpath);
-- 
1.7.6
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 |   
 
| <Prev in Thread] | 
Current Thread | 
[Next in Thread>
 |  
- [Xen-devel] [PATCH 00/13] [PATCH RFC] Paravirtualized ticketlocks, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 02/13] x86/ticketlock: collapse a layer of	functions, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 03/13] xen/pvticketlock: Xen implementation for	PV ticket locks, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 04/13] x86/pvticketlock: use callee-save for	lock_spinning, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 01/13] x86/spinlocks: replace pv spinlocks with	pv ticketlocks, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 11/13] x86/ticketlock: only do kick after doing	unlock, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 12/13] x86/pvticketlock: make sure unlock_kick	pvop call is inlined, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 09/13] x86/pvticketlocks: we only need to kick	if there's waiters,
Jeremy Fitzhardinge <=
 
- [Xen-devel] [PATCH 05/13] x86/ticketlocks: when paravirtualizing	ticket locks, increment by 2, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 10/13] xen/pvticket: allow interrupts to be	enabled while blocking, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 08/13] xen/pvticketlock: disable interrupts	while blocking, Jeremy Fitzhardinge
 
  
 
 |  
  
 | 
    |