WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] IRQ: manually EOI migrating line interrupts

To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] IRQ: manually EOI migrating line interrupts
From: Keir Fraser <keir@xxxxxxx>
Date: Tue, 30 Aug 2011 15:35:46 +0100
Cc:
Delivery-date: Tue, 30 Aug 2011 07:36:34 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=Drjs4+UnJwQ5QTVaiDAlFyz3g62TsWGG11VBVbw7O/k=; b=UxQZMKiZ+sJ670KOwTiNtAyey5incFgrvI4K0276ai57usv/5IG/UM98AZ0fzepeUU N8mi31fAuu7ifZmv3MzvLIrIVL6i3W2Ab9idvxFzbthwxyqnlZVkTnVcxr7+iK7BEoSq v56KeoFhLELtDjVqsJXqviepD/itdqRcUD7L4=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4E5CF393.10903@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcxnIhqdm08Y42CmX0OOpBDzhDsxYQ==
Thread-topic: [PATCH] IRQ: manually EOI migrating line interrupts
User-agent: Microsoft-Entourage/12.30.0.110427
On 30/08/2011 15:28, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx> wrote:

> P.S.
> 
> Because this fix actually works, it means that EOI'ing the IO-APIC is
> keyed only on vector, and not the target CPU.  As a result, having two
> different interrupts in the IO-APIC with the same vector will result in
> problems when trying to EOI one of them.
> 
> I will address this problem as well in my IRQ cleanup, as I cant see any
> checks for it currently.

Isn't this a general issue with per-cpu vector allocations anyway? The usual
irq-completion path of LAPIC EOI -> IO-APIC EOI broadcast will unavoidably
have this issue. Every irq line on every IO-APIC currently programmed with
that vector (regardless of target CPU) will get EOIed/unmasked. Not clear
it's really a problem though! It might cause the odd spurious interrupt
perhaps?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel