WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] p2m: use defines for page sizes

To: Christoph Egger <Christoph.Egger@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] p2m: use defines for page sizes
From: Tim Deegan <tim@xxxxxxx>
Date: Fri, 26 Aug 2011 13:03:26 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 26 Aug 2011 05:06:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4E56439D.9020704@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4E56439D.9020704@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
At 14:44 +0200 on 25 Aug (1314283453), Christoph Egger wrote:
> 
> Use defines for page sizes instead of hardcoding the value.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

Applied, thanks, except for this hunk, where that's not waht 9 means: 

> --- a/xen/arch/x86/mm/p2m-pt.c        Tue Aug 23 14:34:15 2011 +0200
> +++ b/xen/arch/x86/mm/p2m-pt.c        Thu Aug 25 14:29:18 2011 +0200
> @@ -64,7 +64,7 @@ static unsigned long p2m_type_to_flags(p
>       */
>      flags = (unsigned long)(t & 0x7f) << 12;
>  #else
> -    flags = (t & 0x7UL) << 9;
> +    flags = (t & 0x7UL) << PAGE_ORDER_2M;
>  #endif
>  
>  #ifndef __x86_64__

Cheers,

Tim.

-- 
Tim Deegan <tim@xxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>