WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH][VTD] fixing vt-d/ept page table sharing in xen-4

To: "Allen M Kay" <allen.m.kay@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH][VTD] fixing vt-d/ept page table sharing in xen-4.1
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Mon, 22 Aug 2011 08:39:25 +0100
Cc: Yongjie Ren <yongjie.ren@xxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, "keir@xxxxxxx" <keir@xxxxxxx>, Tim Deegan <tim@xxxxxxx>, Xudong Hao <xudong.hao@xxxxxxxxx>, Xin Li <xin.li@xxxxxxxxx>
Delivery-date: Mon, 22 Aug 2011 00:40:09 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <987664A83D2D224EAE907B061CE93D5301EA531481@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <CE59C043D0EC3349B2BF41C0EC72229B12D21111FB@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <CE59C043D0EC3349B2BF41C0EC72229B12D216E382@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20110803171239.GA71832@xxxxxxxxxxxxxxxxxxxxx> <987664A83D2D224EAE907B061CE93D5301EA1F3274@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4E3FAF0F0200007800050178@xxxxxxxxxxxxxxxxxxxx> <20110808151150.GB5845@xxxxxxxxxxxxxxxxxxxxx> <20110810162534.GB11708@xxxxxxxxxxxxxxxxxxxxx> <20110815101159.GG11708@xxxxxxxxxxxxxxxxxxxxx> <20110815104059.GH11708@xxxxxxxxxxxxxxxxxxxxx> <987664A83D2D224EAE907B061CE93D5301EA3F8905@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20110816091320.GL11708@xxxxxxxxxxxxxxxxxxxxx> <987664A83D2D224EAE907B061CE93D5301EA531481@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> On 20.08.11 at 03:47, "Kay, Allen M" <allen.m.kay@xxxxxxxxx> wrote:
> Tim/Keir,
> 
> Attached is a patch for fixing VT-d/EPT sharing issue in xen-4.1-testing.  It 
> is base on Tim's patch with the following changes:
> 
> 1) moving "d->arch.paging.mode = mode | PG_HAP_enable" before calling 
> p2m_alloc_table().  Otherwise, the call to iommu_use_hap_pt() in 
> iommu_set_pgd() will not return TRUE.

Wouldn't you need to revert this change in the error paths that sit
between the new and old places of where this happens/happened?

And is it certain that setting this earlier won't confuse other code?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>