Re: [Xen-devel] [PATCH 1/3] xen/pv-on-hvm kexec: add xs_introduc

To:	Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH 1/3] xen/pv-on-hvm kexec: add xs_introduce to shutdown watches from old kernel
From:	Olaf Hering <olaf@xxxxxxxxx>
Date:	Tue, 9 Aug 2011 11:28:12 +0200
Cc:	Jeremy Fitzhardinge <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Konrad <konrad.wilk@xxxxxxxxxx>
Delivery-date:	Tue, 09 Aug 2011 02:29:35 -0700
Dkim-signature:	v=1; a=rsa-sha1; c=relaxed/relaxed; t=1312882115; l=645; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=aL82+np3S/DLHlL6MP2ygdGqalw=; b=m8AGZr61tZfftBpfm3vTh49+uzz+Y2BqMdJQj1JpIOZeioY6UWCJlq3ubMJfVbFHLhY 4Er42176q2e/sEqxX2+g3G1KMqy09b/4l2cwrS/bQmxD5SgumJfZeTznhKRfuHP1ph2Da ApCKYYTt/a/5AUVOjbD+ohlKBwpVPIUHzTo=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<1312881318.26263.44.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<20110804162053.723541930@xxxxxxxxx> <20110804162054.096018606@xxxxxxxxx> <1312881318.26263.44.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.21.rev5535 (2011-07-01)

On Tue, Aug 09, Ian Campbell wrote:

> > +++ linux-3.0/drivers/xen/xenbus/xenbus_xs.c

> > +   return xs_error(xs_talkv(XBT_NIL, XS_INTRODUCE, iov,
> > +                            ARRAY_SIZE(iov), NULL));
> 
> What should we do if this fails?

There is not much other than printk and move on.
A kexec boot cant be detected from withing kexec.

> > +   snprintf(domid, sizeof(domid), "%u", DOMID_SELF);
> > +   snprintf(mfn, sizeof(mfn), "%lu", xen_store_mfn);
> > +   snprintf(port, sizeof(port), "%d", xen_store_evtchn);
> 
> These can be within the if, or better within the xs_introduce function
> itself.

Yes, thats true. I will rearrange the code.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

Re: [Xen-devel] [PATCH] xenstored: allow guests to reintroduce themselves, Ian Campbell

Next by Date:

Re: [Xen-devel] [PATCH 2/3] xen/pv-on-hvm kexec: rebind virqs to existing eventchannel ports, Olaf Hering

Previous by Thread:

Re: [Xen-devel] [PATCH 1/3] xen/pv-on-hvm kexec: add xs_introduce to shutdown watches from old kernel, Ian Campbell

Next by Thread:

[Xen-devel] [PATCH 3/3] xen/pv-on-hvm kexec+kdump: reset PV devices in kexec or crash kernel, Olaf Hering

Indexes:

[Date] [Thread] [Top] [All Lists]

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH 1/3] xen/pv-on-hvm kexec: add xs_introduce to shu