WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Qemu-devel] [PATCH] xen: Avoid useless allocation in Xe

To: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
Subject: [Xen-devel] Re: [Qemu-devel] [PATCH] xen: Avoid useless allocation in Xen case.
From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Date: Tue, 2 Aug 2011 13:13:26 +0100
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Alexander Graf <agraf@xxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, QEMU-devel <qemu-devel@xxxxxxxxxx>
Delivery-date: Tue, 02 Aug 2011 05:16:07 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=aHudu/+bA409EO2DO74FdRduwtb96BO3id2j+w5G0b8=; b=NoZqLxRx/ESFA4W5St2E39fO6CTZInHy/Zz/KYoFKnLKevjPsu9MJGlWHkQcPYg3EG uFlaBzxigzG4svMz9xmx5QtiB98cHOvIeNjpd9yPiTf9gejdF9f0MpvrvdV6nUmbmZ6s efTsIoko9Z3+JuP7gYBx2LQgGHJc8LPjaL2iM=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4E37D621.3050302@xxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1312226782-26882-1-git-send-email-anthony.perard@xxxxxxxxxx> <4E37052E.70707@xxxxxx> <4E37D621.3050302@xxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, Aug 2, 2011 at 11:49, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:
>> The same applies to kvm, please generalize.
>
> Actually, qemu-kvm avoids this overhead today by making code_gen_alloc
> return immediately when kvm is on. Also not very beautiful.
>
> Can't we simply skip cpu_exec_init_all for any accel != TCG, e.g. by
> moving that call to tcg_init?

In the function cpu_exec_init_all(), the call to cpu_gen_init() (and I
suppose to io_mem_init()) is still required. So we can not move the
whole function to tcg_init().

But I can maybe use "if (!tcg_enabled())" instead of a check to xen.
Until no tcg code is use when kvm/xen is enabled.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel