Re: [Xen-devel] [PATCH 2/6] xen/hvm kexec: unregister shutdown+s

To:	Olaf Hering <olaf@xxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH 2/6] xen/hvm kexec: unregister shutdown+sysrq watches during reboot
From:	Keir Fraser <keir@xxxxxxx>
Date:	Mon, 01 Aug 2011 07:35:48 -0700
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date:	Mon, 01 Aug 2011 07:36:33 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=PeETWwG1I2fnB4y3Et/zGHqbuKYBnRtSz9ZN5z3R994=; b=G48thwZpt5y5ZZhM+Va27uBJDeG4FhySz5NW8pTxqGfde7qcPTmoPAzZQK+WvpDBG/ lIyeSkJB7TyadSBXCZZyOUckggUcarSKnCARkd3pNNVoGGON76nvR/JHtYzDg6O4VGjy cMqukcK2+chhyTDI4CQWbFSJnvJm4aXFk8ZNo=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<20110801130138.GD9956@xxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcxQWE3UgMw2H7HmKEKpXvMPzbZQvw==
Thread-topic:	[Xen-devel] [PATCH 2/6] xen/hvm kexec: unregister shutdown+sysrq watches during reboot
User-agent:	Microsoft-Entourage/12.30.0.110427

On 01/08/2011 06:01, "Olaf Hering" <olaf@xxxxxxxxx> wrote:

>> Hmm, no. Attached patch would be safer, give it a try.
>> 
>> And note that it is *dangerous* to reset the domain xenstore connection if
>> there could be any other concurrent activity on the connection that could
>> confuse the guest kernel. So doing the reset during kernel bringup might be
>> safest, there you can do it in the kernel before the whole xenbus subsystem
>> is fully up.
> 
> I sent a different xenstored patch which takes DOMID_SELF into account.

Saw it, I'll give it a think over. I think it looks okay, I wonder whether
DOMID_SELF handling should be pushed into find_domain_by_domid, but it's a
minor detail really. I certainly support the approach. Hopefully we can get
someone to similarly modify ocaml/xenstored too.

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH 2/6] xen/hvm kexec: unregister shutdown+sysrq wat