xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] x86-64/EFI: don't call EfiResetSystem() from machine

from [Jan Beulich]

[Permanent Link][Original]

To:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [PATCH] x86-64/EFI: don't call EfiResetSystem() from machine_halt()
From:	"Jan Beulich" <JBeulich@xxxxxxxxxx>
Date:	Tue, 19 Jul 2011 09:03:19 +0100
Delivery-date:	Tue, 19 Jul 2011 01:05:17 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

c/s 23615:d19e77844267 was a little too eager in adding calls to EFI
runtime services: machine_halt() doesn't really want to power off the
machine, but that's what EfiResetSystem(EfiResetShutdown, ...) (called
through efi_halt_system()) does.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

--- a/xen/arch/x86/shutdown.c
+++ b/xen/arch/x86/shutdown.c
@@ -96,7 +96,6 @@ void machine_halt(void)
     watchdog_disable();
     console_start_sync();
     local_irq_enable();
-    efi_halt_system();
     smp_call_function(__machine_halt, NULL, 0);
     __machine_halt(NULL);
 }

x86-EFI-no-halt.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] x86-64/EFI: don't call EfiResetSystem() from machine_halt(), Jan Beulich <=

Previous by Date:	[Xen-devel] [PATCH] consolidate buildmakevars2file, Jan Beulich
Next by Date:	[Xen-devel] [xen-unstable test] 8142: regressions - FAIL, xen . org
Previous by Thread:	[Xen-devel] [PATCH] consolidate buildmakevars2file, Jan Beulich
Next by Thread:	[Xen-devel] [xen-unstable test] 8142: regressions - FAIL, xen . org
Indexes:	[Date] [Thread] [Top] [All Lists]