WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 1 of 4] hvm: remove cast from trace_var call for

To: Olaf Hering <olaf@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 1 of 4] hvm: remove cast from trace_var call for HVMOP_xentrace
From: George Dunlap <george.dunlap@xxxxxxxxxx>
Date: Fri, 15 Jul 2011 16:48:56 +0100
Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 15 Jul 2011 08:50:58 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <d0dcdddf5285eba0605a.1310744285@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1310744284@xxxxxxxxxxxx> <d0dcdddf5285eba0605a.1310744285@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

On Fri, 2011-07-15 at 16:38 +0100, Olaf Hering wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@xxxxxxxxx>
> # Date 1310741122 -7200
> # Node ID d0dcdddf5285eba0605a95dfda79b794803fa733
> # Parent  fbb448cf5cba5f441ad94f7783a0a1394fd638f9
> hvm: remove cast from trace_var call for HVMOP_xentrace
> 
> trace_var() takes a void pointer, casting is not needed.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> 
> diff -r fbb448cf5cba -r d0dcdddf5285 xen/arch/x86/hvm/hvm.c
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -3926,8 +3926,7 @@ long do_hvm_op(unsigned long op, XEN_GUE
>  
>          /* Cycles will be taken at the vmexit and vmenter */
>          trace_var(tr.event | TRC_GUEST, 0 /*!cycles*/,
> -                  tr.extra_bytes,
> -                  (unsigned char *)tr.extra);
> +                  tr.extra_bytes, tr.extra);
>          break;
>      }
>  



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel