On 07/15/11 13:27, Roger Pau Monné wrote:
Another one, used -n instead of -z when testing the presence of
XENSTORED_ROOTDIR. Sorry for this mess, I'm not really used to make
shell init scripts.
This version is good.
Acked-by: Christoph Egger <Christoph.Egger@xxxxxxx>
Regards, Roger.
2011/7/15 Ian Campbell<Ian.Campbell@xxxxxxxxxxxxx>:
On Fri, 2011-07-15 at 10:55 +0100, Roger Pau Monné wrote:
Just a minor fix,&>/dev/null used with rm puts the process in the
background, so xenstore might be started before the database was
cleaned.
Oh right, because&>/dev/null is a bash-ism.
Regards, Roger.
2011/7/15 Ian Campbell<Ian.Campbell@xxxxxxxxxxxxx>:
On Fri, 2011-07-15 at 10:18 +0100, Roger Pau Monné wrote:
Thanks for the comments, here is the new patch, changed the commit
message and used the method found on Linux script to wait for xenstore
to come up.
Looks good to me in the general sense, although I can't comment on the
NetBSD specifics.
Acked-by: Ian Campbell<ian.campbell@xxxxxxxxxx>
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home