WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] RE: Window VM hit blue screen when dom0 uses ext4 with e

To: MaoXiaoyun <tinnycloud@xxxxxxxxxxx>
Subject: Re: [Xen-devel] RE: Window VM hit blue screen when dom0 uses ext4 with extent enabled
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Thu, 14 Jul 2011 09:02:06 +0100
Cc: "jeremy@xxxxxxxx" <jeremy@xxxxxxxx>, xen devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>
Delivery-date: Thu, 14 Jul 2011 01:05:50 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <BLU157-w588C52B32EEFC7D266C6E4DA460@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <BAY0-MC1-F37Yf41i9900243d6c@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <BLU157-w588C52B32EEFC7D266C6E4DA460@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2011-07-14 at 06:44 +0100, MaoXiaoyun wrote:
> I think the 2.6.32.36 ext4 needs to backport this patch much likely.
> Otherwise it will hit the problem I met.
>  
> http://patchwork.ozlabs.org/patch/79880/

That version is still in state NEW but something appears to have been
committed upstream as e9e3bcecf44c04b9e6b505fd8e2eb9cea58fb94d:

    ext4: serialize unaligned asynchronous DIO
    
    ext4 has a data corruption case when doing non-block-aligned
    asynchronous direct IO into a sparse file, as demonstrated
    by xfstest 240.
    
    ...

Seems like a reasonable enough thing to backport to me (for what that's
worth). Although:
                            It is also quite a lot slower
    (14 min for package installs, vs. 8 min for well-aligned)
    but I'll take slow correctness over fast corruption any day.
    
    Mingming suggested that we can track outstanding
    conversions, and wait on those so that non-sparse
    files won't be affected, and I've implemented that here;
    unaligned AIO to nonsparse files won't take a perf hit.

Something to bear in mind if you are deploying anything based on sparse
files on ext4.

Ian.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel