WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH v2] xen-netfront: delay gARP until backend switch

To: Laszlo Ersek <lersek@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH v2] xen-netfront: delay gARP until backend switches to Connected
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Wed, 13 Jul 2011 09:29:52 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx
Delivery-date: Wed, 13 Jul 2011 06:30:51 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1310557487-6094-1-git-send-email-lersek@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20110712181912.GA32232@xxxxxxxxxxxx> <1310557487-6094-1-git-send-email-lersek@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jul 13, 2011 at 01:44:47PM +0200, Laszlo Ersek wrote:
> In addition to backporting 43223efd9bfd to the RHEL-5 host side, we needed the
> following in the RHEL-6 guest, in order to fix the network outage after live
> migration. I also tested a Fedora-15 guest (without the patch), and the

Laszlo,

This description is .. well, pointless for upstream patches. Just succinctly
describe the problem, how to reproduce it, and what this patch does.

And do mention more about 43223efd9bfd, like "this is the front
counterpart of patch xen: netback: wait for hotplug scripts to complete before
signalling connected to frontend (43223efd9bfd)"

> backport to the host side alone was not sufficient there either. Therefore I
> think it could be useful to apply this guest-side patch to upstream as well.
> 
> Reference: https://bugzilla.redhat.com/show_bug.cgi?id=713585
> 
> v1->v2: "port" to Linus's tree; add RHBZ ref.
> 
> Signed-off-by: Laszlo Ersek <lersek@xxxxxxxxxx>
> ---
>  drivers/net/xen-netfront.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index d29365a..f033656 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -1646,7 +1646,6 @@ static void netback_changed(struct xenbus_device *dev,
>       case XenbusStateInitialised:
>       case XenbusStateReconfiguring:
>       case XenbusStateReconfigured:
> -     case XenbusStateConnected:
>       case XenbusStateUnknown:
>       case XenbusStateClosed:
>               break;
> @@ -1657,6 +1656,9 @@ static void netback_changed(struct xenbus_device *dev,
>               if (xennet_connect(netdev) != 0)
>                       break;
>               xenbus_switch_state(dev, XenbusStateConnected);
> +             break;
> +
> +     case XenbusStateConnected:
>               netif_notify_peers(netdev);
>               break;
>  
> -- 
> 1.7.4.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel