branch xen-unstable
xen branch xen-unstable
job test-amd64-i386-rhel6hvm-intel
test redhat-install
Tree: linux git://git.eu.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git
Tree: qemu git://hg.uk.xensource.com/HG/qemu-xen-unstable.git
Tree: xen http://hg.uk.xensource.com/xen-unstable.hg
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://hg.uk.xensource.com/xen-unstable.hg
Bug introduced: 0a70aeba14e2
Bug not present: d5dfaa568441
changeset: 23657:0a70aeba14e2
user: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
date: Wed Jul 06 18:26:49 2011 +0100
libxl: sane disk backend selection and validation
Introduce a new function libxl__device_disk_set_backend which
does some sanity checks and determines which backend ought to be used.
If the caller specifies LIBXL_DISK_BACKEND_UNKNOWN (which has the
value 0), it tries PHY, TAP and QDISK in that order. Otherwise it
tries only the specified value.
libxl__device_disk_set_backend (and its helper function
disk_try_backend) inherit the role (and small amounts of the code)
from validate_virtual_disk. This is called during do_domain_create
and also from libxl_disk_device_add (for the benefit of hotplug
devices).
It also now takes over the role of the scattered fragments of backend
selection found in libxl_device_disk_add,
libxl_device_disk_local_attach and libxl__need_xenpv_qemu. These
latter functions now simply do the job for the backend they find has
already been specified and checked.
The restrictions on the capabilities of each backend, as expressed in
disk_try_backend (and to an extent in libxl_device_disk_local_attach)
are intended to be identical to the previous arrangements.
In 23618:3173b68c8a94 combined with 23622:160f7f39841b,
23623:c7180c353eb2, "xl" effectively became much more likely to select
TAP as the backend. With this change to libxl the default backend
selected by the libxl__device_disk_set_backend is intended to once
again to be PHY where possible.
Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
For bisection revision-tuple graph see:
http://www.chiark.greenend.org.uk/~xensrcts/results/bisect.xen-unstable.test-amd64-i386-rhel6hvm-intel.redhat-install.html
Revision IDs in each graph node refer, respectively, to the Trees above.
----------------------------------------
Searching for failure / basis pass:
7980 fail [host=earwig] / 7922 ok.
Failure / basis pass flights: 7980 / 7922
Tree: linux git://git.eu.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git
Tree: qemu git://hg.uk.xensource.com/HG/qemu-xen-unstable.git
Tree: xen http://hg.uk.xensource.com/xen-unstable.hg
Latest 6d94b752e1363757f8eb4558e6f721a3e703cfe2
cd776ee9408ff127f934a707c1a339ee600bc127 0a70aeba14e2
Basis pass 6d94b752e1363757f8eb4558e6f721a3e703cfe2
cd776ee9408ff127f934a707c1a339ee600bc127 7e4404a8f5f9
Generating revisions with ./adhoc-revtuple-generator
git://git.eu.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git#6d94b752e1363757f8eb4558e6f721a3e703cfe2-6d94b752e1363757f8eb4558e6f721a3e703cfe2
git://hg.uk.xensource.com/HG/qemu-xen-unstable.git#cd776ee9408ff127f934a707c1a339ee600bc127-cd776ee9408ff127f934a707c1a339ee600bc127
http://hg.uk.xensource.com/xen-unstable.hg#7e4404a8f5f9-0a70aeba14e2
pulling from http://hg.uk.xensource.com/xen-unstable.hg
searching for changes
no changes found
pulling from http://hg.uk.xensource.com/xen-unstable.hg
searching for changes
no changes found
Loaded 28 nodes in revision graph
Searching for test results:
7995 fail 6d94b752e1363757f8eb4558e6f721a3e703cfe2
cd776ee9408ff127f934a707c1a339ee600bc127 0a70aeba14e2
7889 [host=gall-mite]
7896 pass 6d94b752e1363757f8eb4558e6f721a3e703cfe2
cd776ee9408ff127f934a707c1a339ee600bc127 7e4404a8f5f9
7904 [host=gall-mite]
7978 [host=itch-mite]
7914 [host=gall-mite]
7980 fail 6d94b752e1363757f8eb4558e6f721a3e703cfe2
cd776ee9408ff127f934a707c1a339ee600bc127 0a70aeba14e2
7985 [host=itch-mite]
7922 pass 6d94b752e1363757f8eb4558e6f721a3e703cfe2
cd776ee9408ff127f934a707c1a339ee600bc127 7e4404a8f5f9
7986 pass 6d94b752e1363757f8eb4558e6f721a3e703cfe2
cd776ee9408ff127f934a707c1a339ee600bc127 7e4404a8f5f9
7987 fail 6d94b752e1363757f8eb4558e6f721a3e703cfe2
cd776ee9408ff127f934a707c1a339ee600bc127 0a70aeba14e2
7989 pass 6d94b752e1363757f8eb4558e6f721a3e703cfe2
cd776ee9408ff127f934a707c1a339ee600bc127 d5dfaa568441
7990 fail 6d94b752e1363757f8eb4558e6f721a3e703cfe2
cd776ee9408ff127f934a707c1a339ee600bc127 0a70aeba14e2
7991 pass 6d94b752e1363757f8eb4558e6f721a3e703cfe2
cd776ee9408ff127f934a707c1a339ee600bc127 d5dfaa568441
7992 fail 6d94b752e1363757f8eb4558e6f721a3e703cfe2
cd776ee9408ff127f934a707c1a339ee600bc127 0a70aeba14e2
7993 pass 6d94b752e1363757f8eb4558e6f721a3e703cfe2
cd776ee9408ff127f934a707c1a339ee600bc127 d5dfaa568441
Searching for interesting versions
Result found: flight 7896 (pass), for basis pass
Result found: flight 7980 (fail), for basis failure
Repro found: flight 7986 (pass), for basis pass
Repro found: flight 7987 (fail), for basis failure
0 revisions at 6d94b752e1363757f8eb4558e6f721a3e703cfe2
cd776ee9408ff127f934a707c1a339ee600bc127 d5dfaa568441
No revisions left to test, checking graph state.
Result found: flight 7989 (pass), for last pass
Result found: flight 7990 (fail), for first failure
Repro found: flight 7991 (pass), for last pass
Repro found: flight 7992 (fail), for first failure
Repro found: flight 7993 (pass), for last pass
Repro found: flight 7995 (fail), for first failure
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://hg.uk.xensource.com/xen-unstable.hg
Bug introduced: 0a70aeba14e2
Bug not present: d5dfaa568441
pulling from http://hg.uk.xensource.com/xen-unstable.hg
searching for changes
no changes found
changeset: 23657:0a70aeba14e2
user: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
date: Wed Jul 06 18:26:49 2011 +0100
libxl: sane disk backend selection and validation
Introduce a new function libxl__device_disk_set_backend which
does some sanity checks and determines which backend ought to be used.
If the caller specifies LIBXL_DISK_BACKEND_UNKNOWN (which has the
value 0), it tries PHY, TAP and QDISK in that order. Otherwise it
tries only the specified value.
libxl__device_disk_set_backend (and its helper function
disk_try_backend) inherit the role (and small amounts of the code)
from validate_virtual_disk. This is called during do_domain_create
and also from libxl_disk_device_add (for the benefit of hotplug
devices).
It also now takes over the role of the scattered fragments of backend
selection found in libxl_device_disk_add,
libxl_device_disk_local_attach and libxl__need_xenpv_qemu. These
latter functions now simply do the job for the backend they find has
already been specified and checked.
The restrictions on the capabilities of each backend, as expressed in
disk_try_backend (and to an extent in libxl_device_disk_local_attach)
are intended to be identical to the previous arrangements.
In 23618:3173b68c8a94 combined with 23622:160f7f39841b,
23623:c7180c353eb2, "xl" effectively became much more likely to select
TAP as the backend. With this change to libxl the default backend
selected by the libxl__device_disk_set_backend is intended to once
again to be PHY where possible.
Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Revision graph left in
/home/xc_osstest/results/bisect.xen-unstable.test-amd64-i386-rhel6hvm-intel.redhat-install.{dot,ps,png,html}.
----------------------------------------
7995: ALL FAIL
flight 7995 xen-unstable real-bisect [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/7995/
jobs:
test-amd64-i386-rhel6hvm-intel fail
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home