[Xen-devel] Re: [xen-unstable test] 7980: regressions - FAIL

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

xen.org writes ("[xen-unstable test] 7980: regressions - FAIL"):
> flight 7980 xen-unstable real [real]
> http://www.chiark.greenend.org.uk/~xensrcts/logs/7980/
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking:
>  test-amd64-i386-rhel6hvm-intel  7 redhat-install       fail REGR. vs. 7749

There seem to be multiple problems here.  One of them is fixed by the
change below, just committed.

Ian.

# HG changeset patch
# User Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
# Date 1310038505 -3600
# Node ID 21ff10d9a61779b4cee4b3c454ddb004a20f44dd
# Parent  0a70aeba14e2ddc1f64fd2f0548e2c5b3f043cd9
libxl: fix incorrect return of ERROR_INVAL from disk_try_backend

disk_try_backend is supposed to return 0 or the disk backend format.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

diff -r 0a70aeba14e2 -r 21ff10d9a617 tools/libxl/libxl_device.c
--- a/tools/libxl/libxl_device.c        Wed Jul 06 18:26:49 2011 +0100
+++ b/tools/libxl/libxl_device.c        Thu Jul 07 12:35:05 2011 +0100
@@ -145,7 +145,7 @@ static int disk_try_backend(disk_try_bac
             LIBXL__LOG(ctx, LIBXL__LOG_DEBUG, "Disk vdev=%s, backend phy"
                        " unsuitable as phys path not a block device",
                        a->disk->vdev);
-            return ERROR_INVAL;
+            return 0;
         }
 
         return backend;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel