 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH 1 of 5] Nested p2m: implement "flush" as a first-
| To: | Tim Deegan <Tim.Deegan@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH 1 of 5] Nested p2m: implement "flush" as a first-class action |
| From: | Olaf Hering <olaf@xxxxxxxxx> |
| Date: | Thu, 30 Jun 2011 11:51:05 +0200 |
| Cc: | Christoph Egger <Christoph.Egger@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Thu, 30 Jun 2011 02:51:39 -0700 |
| Dkim-signature: | v=1; a=rsa-sha1; c=relaxed/relaxed; t=1309427466; l=823; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=9qV/WmkIjqi7CBF1cN7ezJBTBCI=; b=Mf5RPfxU0gMiSrYGTpYclTAUqbaP01ddx4ZROORcNNyemeu7FUQFsH56+qsKXj/NVl5 HJn2LNteWRXTyxYPHp+nPvmdOP/Y55PZMuOlXfPcpdVfROfMo+brV3fjQXBVYd0t9Vobi b/jylcAG6/AzftPQvsAY1UzhmN8r/921qww= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <44c7b977302663487922.1309171571@xxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <patchbomb.1309171570@xxxxxxxxxxxxxxxxxxxxxxx> <44c7b977302663487922.1309171571@xxxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mutt/1.5.21.rev5529 (2011-06-25) |
On Mon, Jun 27, Tim Deegan wrote:
> diff -r b24018319772 -r 44c7b9773026 xen/arch/x86/mm/p2m.c
> --- a/xen/arch/x86/mm/p2m.c Thu Jun 23 18:34:55 2011 +0100
> +++ b/xen/arch/x86/mm/p2m.c Fri Jun 24 16:24:44 2011 +0100
> @@ -1050,20 +1050,41 @@ p2m_getlru_nestedp2m(struct domain *d, s
> return lrup2m;
> }
>
> -static int
> +/* Reset this p2m table to be empty */
> +static void
> p2m_flush_locked(struct p2m_domain *p2m)
> {
> - ASSERT(p2m);
> - if (p2m->cr3 == CR3_EADDR)
> - /* Microoptimisation: p2m is already empty.
> - * => about 0.3% speedup of overall system performance.
> - */
> - return 0;
> + struct page_info *top, *pg;
> + struct domain *d = p2m->domain;
Tim,
one of these changes causes a build error:
p2m.c:1105:20: error: unused variable 'd' [-Werror=unused-variable]
Olaf
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH 0 of 5] v2: Nested-p2m cleanups and locking changes, Tim Deegan |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH 1 of 5] Nested p2m: implement "flush" as a first-class action, Tim Deegan |
| Previous by Thread: | [Xen-devel] [PATCH 1 of 5] Nested p2m: implement "flush" as a first-class action, Tim Deegan |
| Next by Thread: | Re: [Xen-devel] [PATCH 1 of 5] Nested p2m: implement "flush" as a first-class action, Tim Deegan |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
