WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH v2] xen_console: support the new extended xen

On Tue, 28 Jun 2011, Ian Campbell wrote:
> On Tue, 2011-06-28 at 16:02 +0100, Peter Maydell wrote:
> > On 28 June 2011 15:55,  <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> > > +    xs = xs_daemon_open();
> > > +    if (xs == NULL) {
> > > +        fprintf(stderr, "Could not contact XenStore\n");
> > > +        goto out;
> > > +    }
> > 
> > > +out:
> > > +    free(path);
> > > +    xs_daemon_close(xs);
> > 
> > Google suggests xs_daemon_close(NULL) will crash...
> 
> Also the preferred interface these days is just xs_open/close. The other
> variants are deprecated.

And xs_close doesn't crash if the parameter is NULL, so it will kill two
birds with one stone.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>