WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [Xen-devel] [PATCH 3 of 3] remus: handle exceptions while installing

from [Ian Jackson] [Permanent Link][Original]
To: Brendan Cully <brendan@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3 of 3] remus: handle exceptions while installing/unstalling net buffer
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Tue, 21 Jun 2011 18:06:26 +0100
Cc: Shriram Rajagopalan <rshriram@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, ian.jackson@xxxxxxxxxxxxx
Delivery-date: Tue, 21 Jun 2011 10:10:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <B9E1AECF-165E-4732-B852-84893DD10EEC@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <patchbomb.1307361109@xxxxxxxxxxxxxxxxxxx> <0af6803eeb9f278abd17.1307361112@xxxxxxxxxxxxxxxxxxx> <B9E1AECF-165E-4732-B852-84893DD10EEC@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
Brendan Cully writes ("Re: [Xen-devel] [PATCH 3 of 3] remus: handle exceptions 
while installing/unstalling net buffer"):
> Bare except clauses are bad style. Please only handle the exact
> exceptions you are expecting.
> 
> Nacked-by: Brendan Cully <brendan@xxxxxxxxx>

I agree.  Shriram ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [Xen-devel] slow xp hibernation revisited, Ian Jackson
Next by Date:  Re: [Xen-devel] [PATCH] Add xl domUs default configuration file, Ian Jackson
Previous by Thread:  Re: [Xen-devel] [PATCH 3 of 3] remus: handle exceptions while installing/unstalling net buffer, Brendan Cully
Next by Thread:  Re: [Xen-devel] [PATCH 3 of 3] remus: handle exceptions while installing/unstalling net buffer, Shriram Rajagopalan
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy