WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 3 of 7] IOMMU: Sanitise pointer work

To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3 of 7] IOMMU: Sanitise pointer work
From: Keir Fraser <keir@xxxxxxx>
Date: Tue, 14 Jun 2011 12:51:34 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 14 Jun 2011 04:52:20 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:user-agent:date:subject:from:to:cc :message-id:thread-topic:thread-index:in-reply-to:mime-version :content-type:content-transfer-encoding; bh=S72txSO7adJdepI96N07L+Slu7djVKfh4SMxq/kZ4Dw=; b=uBVIBJu7F1uJQ2KodE/VYoDJvu7ToSVX8lmf8HQpANmT/rn4ea9vhtZWKPHO+cwXfz OppgRvvbNfCn62OcL0vlHDVgXsSq1hpxTyDXzF8YJxqZxVs7cIgrvfJR3PiG+/XnC+UU jL7LHpHsx7W67jADYTdSytwm9mPoszyV8/SsQ=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=V3e39rcAkFyjyYq65UBYBLDnMYTcemVy+m78MAgFcG5rWFx047kF1z6i2R8EwzmkCK 5WJ1nTlrwlmPRIaspZDPGjFrtRuSLUToi+HtZLaS9PZ9FwnfudrVCAQBte7SQZGUm2iz 3KCQvu1GHxR8SpjwO71sIcTg/eYZnpsOrXOyw=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4DF72FB1.9090507@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcwqiWiP/HJfjsWgJkuD5soG8YBMOw==
Thread-topic: [Xen-devel] [PATCH 3 of 7] IOMMU: Sanitise pointer work
User-agent: Microsoft-Entourage/12.29.0.110113
On 14/06/2011 10:53, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx> wrote:

> On 13/06/11 19:13, Keir Fraser wrote:
>> On 13/06/2011 18:02, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx> wrote:
>> 
>>> Check for null pointers before calling function pointers.
>> But they're never NULL? This one's a bit pointless.
>> 
>>  -- Keir
>> 
> This patch was a direct result of comments regarding my previous attempt
> to make a crash_shutdown iommu_op.  Are we happy to assume that noone in
> the future is going to partially implement an iommu_ops structure?

We'll cross that bridge if we come to it. I can't see anyone implementing
iommu_ops that don't need a call back on suspend and resume.

 -- Keir

> ~Andrew
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>> 
>>> diff -r 1c3d2e4d06fe -r 68efd418b6f1 xen/drivers/passthrough/iommu.c
>>> --- a/xen/drivers/passthrough/iommu.c Mon Jun 13 17:45:43 2011 +0100
>>> +++ b/xen/drivers/passthrough/iommu.c Mon Jun 13 17:45:43 2011 +0100
>>> @@ -407,17 +407,17 @@ unsigned int iommu_read_apic_from_ire(un
>>>      return ops->read_apic_from_ire(apic, reg);
>>>  }
>>>  
>>> -void iommu_resume()
>>> +void iommu_resume(void)
>>>  {
>>>      const struct iommu_ops *ops = iommu_get_ops();
>>> -    if ( iommu_enabled )
>>> +    if ( iommu_enabled && ops && ops->resume )
>>>          ops->resume();
>>>  }
>>>  
>>> -void iommu_suspend()
>>> +void iommu_suspend(void)
>>>  {
>>>      const struct iommu_ops *ops = iommu_get_ops();
>>> -    if ( iommu_enabled )
>>> +    if ( iommu_enabled && ops && ops->suspend )
>>>          ops->suspend();
>>>  }
>>>  
>>> 
>>> _______________________________________________
>>> Xen-devel mailing list
>>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>>> http://lists.xensource.com/xen-devel
>> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>