 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] Bug in smpboot.c?
| To: | "John McDermott (U.S. Navy Employee)" <john.mcdermott@xxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] Bug in smpboot.c? |
| From: | Keir Fraser <keir.xen@xxxxxxxxx> |
| Date: | Thu, 09 Jun 2011 23:09:32 +0100 |
| Cc: | |
| Delivery-date: | Thu, 09 Jun 2011 15:11:35 -0700 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=PAfeXcadMvhs7fleNHN7p/qbBd06MICL2nA4k14IUXk=; b=aK24fadvGl3UHxwij8BexIq7MHwtippr53L3RCMz14+/RlWew0Soq9WuQHrSnhRqTl FjzpxHLp3yP5pbznvfyPi3zKFl/kxMF6YY0jFQ6ngT0v4ti6LORyot2ggUvU7fMfZvzK I50DKFjTaHtQEtQ3dmUDgMkeY/2evySO5QfqQ= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=BRVSrbf72gKkrX93F2L6SrvTogKxVyUxHWK3mih7kQ/6qMpK50Jna08l4zt8FGjKTw u/W5zvIUbbJBPkU4C2AgqIougOnBBew8NEzAZ85tlHLxCSZJwg7tJg9oVUVCjKeQA0IN mtHzi11MhP6BxdIFfkQi6zDKqdAlTHum60iVU= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <FF7C94F8-BCD0-4B8F-8574-201BAF6C3FA2@xxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acwm8ei0Bw+DOsTeG0qq3AI37qSa+Q== |
| Thread-topic: | [Xen-devel] Bug in smpboot.c? |
| User-agent: | Microsoft-Entourage/12.29.0.110113 |
On 09/06/2011 16:49, "John McDermott (U.S. Navy Employee)" <john.mcdermott@xxxxxxxxxxxx> wrote: > Xen Developers, > > In C function cpu_add(), in xen/arch/x86/smpboot.c, if acpi_id == > MAX_MADT_ENTRIES, won't this write past the end of array > x86_acpiid_toapicid[MAX_MADT_ENTRIES]? I am looking at xen-unstable. It looks > like the guard is not catching this 1 case? Looks like it. Also the check against MAX_APICS, and the pxm value against 256, are all similarly off by one. Thanks for spotting it! -- Keir > Sincerely, > > John McDermott > ---- > What is the formal meaning of the one-line program > #include "/dev/tty" > > J.P. McDermott building 12 > Code 5542 mcdermott@xxxxxxxxxxxxxxxx > Naval Research Laboratory voice: +1 202.404.8301 > Washington, DC 20375, US fax: +1 202.404.7942 > > > > > > > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@xxxxxxxxxxxxxxxxxxx > http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] Re: vsyscalls may be going away... impact on Xen time performance on Linux in the future?, Jeremy Fitzhardinge |
|---|---|
| Next by Date: | RE: [Xen-devel] Re: vsyscalls may be going away... impact on Xen time performance on Linux in the future?, Dan Magenheimer |
| Previous by Thread: | [Xen-devel] Bug in smpboot.c?, John McDermott (U.S. Navy Employee) |
| Next by Thread: | [Xen-devel] Addback capability check for non-initial features, Dong, Eddie |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
