On Fri, 2011-06-03 at 12:13 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH 8/9] xl: xl block-attach -N (dry
> run) option"):
> > On Thu, 2011-06-02 at 18:55 +0100, Ian Jackson wrote:
> > > - if ((opt = def_getopt(argc, argv, "", "block-attach", 2)) != -1)
> > > - return opt;
> > > + while ((opt = getopt(argc, argv, "Nh")) != -1) {
> >
> > You've undone part of 23299:39f2942fe56b here, not on purpose?
>
> The def_getopt only works if the command doesn't have any nonstandard
> options, AFAICT.
I think it does work, the "" above is the nonstandard options
specification e.g. main_console takes -n and -t options:
while ((opt = def_getopt(argc, argv, "n:t:", "console", 1)) != -1) {
switch (opt) {
case 0: case 2:
return opt;
case 't':
[...]
break;
case 'n':
[...]
> But if we move -N into the global options this becomes unnecessary.
Yes.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home