Re: [Xen-devel] [PATCH 08/14] libxl: disks: new xlu_disk_parse function

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH 08/14] libxl: disks: new 
xlu_disk_parse function"):
> On Thu, 2011-05-12 at 15:36 +0100, Ian Jackson wrote:
> > [...]
...
> Something seems to be up with the leading whitespace here.

Fixed.

> > +   * string containing a collection of parameters (but they all refer
> > +   * to of the configuration for a single disk).
>            ^^ what is that doing there?

Fixed.

....
> This is the third time this week I've wondered if a patch ought to come
> along with a library of test inputs and expected outputs. I'll be
> proposing we switch to the waterfall model before you know it...

My series repost will include one, since it seemed useful.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel