WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] xen/apic: use xen_apic for all pv guests, not just d

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] xen/apic: use xen_apic for all pv guests, not just dom0.
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Wed, 1 Jun 2011 16:48:15 +0100
Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Wed, 01 Jun 2011 08:49:53 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
c3dd7941354f "xen/apic: Provide an 'apic_xen' to set the override the
apic->[read|write] for all cases" caused my 32 bit domU to panic with:
[    0.000000] Kernel panic - not syncing: Didn't find an APIC driver
[    0.000000] Pid: 0, comm: swapper Not tainted 
2.6.32.41-x86_32p-xenU-01177-g22982d8-dirty #233
[    0.000000] Call Trace:
[    0.000000]  [<c11f8284>] ? printk+0xf/0x13
[    0.000000]  [<c11f81b8>] panic+0x39/0xf6
[    0.000000]  [<c1308f60>] generic_apic_probe+0x72/0x8a
[    0.000000]  [<c1301cd3>] setup_arch+0x90f/0x966
[    0.000000]  [<c102e5c1>] ? vprintk+0x368/0x38a
[    0.000000]  [<c104b9bb>] ? lockdep_init_map+0x87/0x40f
[    0.000000]  [<c104aed9>] ? debug_check_no_locks_freed+0x122/0x147
[    0.000000]  [<c12fc5ca>] start_kernel+0x90/0x30e
[    0.000000]  [<c12fc0a8>] i386_start_kernel+0x97/0x9e
[    0.000000]  [<c12ff372>] xen_start_kernel+0x4ce/0x4d6

Add the APIC override for PV guests as well as dom0.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
---
 arch/x86/xen/enlighten.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index 0493093..7cb12e0 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -761,7 +761,7 @@ static __init int xen_safe_flat_acpi_madt_oem_check(char 
*oem_id,
 
 static __init int xen_safe_probe(void) {
 
-       if (!xen_initial_domain())
+       if (!xen_pv_domain())
                return 0;
 
        return 1;
-- 
1.7.2.5


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel