WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH 03 of 15] hvmloader: setup PCI bus in a commo

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH 03 of 15] hvmloader: setup PCI bus in a common function again
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Wed, 1 Jun 2011 11:44:07 +0100
Delivery-date: Wed, 01 Jun 2011 03:46:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1306922740.775.227.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <patchbomb.1306921195@xxxxxxxxxxxxxxxxxxxxxxxxx> <8a7fb25fff1980aa4fcf.1306921198@xxxxxxxxxxxxxxxxxxxxxxxxx> <1306922740.775.227.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2011-06-01 at 11:05 +0100, Ian Campbell wrote:
> On Wed, 2011-06-01 at 10:39 +0100, Ian Campbell wrote:
> > # HG changeset patch
> > # User Ian Campbell <ian.campbell@xxxxxxxxxx>
> > # Date 1306916881 -3600
> > # Node ID 8a7fb25fff1980aa4fcf963da1aa82d4dfd34bda
> > # Parent  062bc0a35d9933cc64c11f861609559e11994778
> > hvmloader: setup PCI bus in a common function again.
> 
> Reposting, updated for changed patch 2/15.

Gah, not sure what I build tested, but it obviously wasn't this code...
Incremental fix (to avoid reposting both 2/15 and 3/15) below.

diff -r 439f07b2d43e tools/firmware/hvmloader/pci.c
--- a/tools/firmware/hvmloader/pci.c    Wed Jun 01 11:04:18 2011 +0100
+++ b/tools/firmware/hvmloader/pci.c    Wed Jun 01 11:43:30 2011 +0100
@@ -81,7 +81,6 @@ void pci_setup(void)
         {
         case 0x0300:
             /* If emulated VGA is found, preserve it as primary VGA. */
-            if ( virtual_vga == VGA_none )
             if ( (vendor_id == 0x1234) && (device_id == 0x1111) )
             {
                 vga_devfn = devfn;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel