|  |  | 
  
    |  |  | 
 
  |   |  | 
  
    |  |  | 
  
    |  |  | 
  
    |   xen-devel
[Xen-devel] RE: [PATCH] CPUID level 0x00000007:0 (ebx) is word 9, instea 
| To: | Jan Beulich <JBeulich@xxxxxxxxxx>, Keir Fraser <keir.xen@xxxxxxxxx> |  
| Subject: | [Xen-devel] RE: [PATCH] CPUID level 0x00000007:0 (ebx) is word 9, instead	 of word 7 |  
| From: | "Li, Xin" <xin.li@xxxxxxxxx> |  
| Date: | Tue, 31 May 2011 22:59:48 +0800 |  
| Accept-language: | zh-CN, en-US |  
| Acceptlanguage: | zh-CN, en-US |  
| Cc: | xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx> |  
| Delivery-date: | Tue, 31 May 2011 14:08:06 -0700 |  
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |  
| In-reply-to: | <4DE501230200007800044777@xxxxxxxxxxxxxxxxxx> |  
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |  
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |  
| List-post: | <mailto:xen-devel@lists.xensource.com> |  
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |  
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |  
| References: | <FC2FB65B4D919844ADE4BE3C2BB739AD5AA820E8@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>	<CA0AA016.1B4F6%keir.xen@xxxxxxxxx>	<4DE501230200007800044777@xxxxxxxxxxxxxxxxxx> |  
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |  
| Thread-index: | AcwfkeSkYQ/EwDSmQdidVzaB6vSURgAECeuA |  
| Thread-topic: | [PATCH] CPUID level 0x00000007:0 (ebx) is word 9, instead	 of	word 7 |  
| > >> CPUID level 0x00000007:0 (ebx) is word 9, instead of word 7.
> >>
> >> ... make it consistent with native Linux.
> >
> > This is just a cleanup, not a bug fix?
> 
> If the patch was quoted in its entirety (didn't see the original in my
> inbox), this is rather introducing a bug (since NCAPINTS is 8). I also
Yes it's introducing a bug, I did not notice NCAPINTS is 8.
> can't see why we would need to stay in sync with Linux's capability
> array indices.
why?  Typically we reuse Linux code unless Xen has its special logic.
-Xin
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 | 
 |  | 
  
    |  |  |