WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2/2] libxc: enabling emulated MSI injection

To: Wei Liu <liuw@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2/2] libxc: enabling emulated MSI injection
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Thu, 26 May 2011 09:05:56 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Thu, 26 May 2011 06:07:03 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <BANLkTimbENZYPabSHNQh08XA-OYEsJ3XkA@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <BANLkTi=PDEZzOOXsmzYVfuCnNf9uaOt_EQ@xxxxxxxxxxxxxx> <20110526123452.GA3386@xxxxxxxxxxxx> <BANLkTimbENZYPabSHNQh08XA-OYEsJ3XkA@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
> >> +    hypercall.op     = __HYPERVISOR_hvm_op;
> >> +    hypercall.arg[0] = HVMOP_inj_msi;
> >> +    hypercall.arg[1] = HYPERCALL_BUFFER_AS_ARG(arg);
> >> +
> >> +    arg->domid = dom;
> >> +    arg->addr  = addr;
> >> +    arg->data  = data;
> >
> > Shouldn't those be done before you make the HYPERCALL_BUFFER_AS_ARG
> > in case they get bounced?
> >
> 
> Hmm... I didn't think that far.
> 
> I just copy-and-edit from a previous hypercall. I think that should be OK 
> then.

On a second look at the code, I believe you are right.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel