|  |  | 
  
    |  |  | 
 
  |   |  | 
  
    |  |  | 
  
    |  |  | 
  
    |   xen-devel
Re: [Xen-devel] [PATCH 1/2] Xen: enabling emulated MSI injection 
| On 26/05/2011 09:43, "Tim Deegan" <Tim.Deegan@xxxxxxxxxx> wrote:
>> +/* MSI injection for emulated devices */
>> +#define HVMOP_inj_msi         16
>> +struct xen_hvm_inj_msi {
>> +    /* Domain to be injected */
>> +    domid_t   domid;
>> +    /* Address (0xfeeXXXXX) */
>> +    uint64_t  addr;
>> +    /* Data -- lower 32 bits */
>> +    uint32_t  data;
>> +};
> 
> Please rearrange this so that it has the same size and layout on 32-bit
> and 64-bit builds.
You can do this most easily be simply swapping the second and third fields.
 -- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 | 
 |  | 
  
    |  |  |