WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] tools: Fix build failure with gcc 4.4.3-4ubuntu5

To: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] tools: Fix build failure with gcc 4.4.3-4ubuntu5
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Mon, 16 May 2011 13:02:18 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 16 May 2011 05:05:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19736875b3ab7bde47fd.1305543906@elijah>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <19736875b3ab7bde47fd.1305543906@elijah>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2011-05-16 at 12:05 +0100, George Dunlap wrote:
> c/s 23253:a3db6b91f32d causes build failure with gcc 4.4.3-4ubuntu5,
> as the compiler can't figure out that the value returned is always
> a string literal.
> 
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> diff -r f9bb0bbea7c2 -r 19736875b3ab tools/libxl/libxl_dm.c
> --- a/tools/libxl/libxl_dm.c  Thu May 12 16:42:54 2011 +0100
> +++ b/tools/libxl/libxl_dm.c  Mon May 16 12:04:47 2011 +0100
> @@ -773,7 +773,7 @@ int libxl__create_device_model(libxl__gc
>      path = libxl__sprintf(gc, "/local/domain/%d/hvmloader", info->domid);
>      xs_mkdir(ctx->xsh, XBT_NULL, path);
>      libxl__xs_write(gc, XBT_NULL, libxl__sprintf(gc, "%s/bios", path),
> -                    libxl__domain_bios(gc, info));
> +                    "%s", libxl__domain_bios(gc, info));
>  
>      path = libxl__sprintf(gc, "/local/domain/0/device-model/%d", 
> info->domid);
>      xs_mkdir(ctx->xsh, XBT_NULL, path);
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>