WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH linux-2.6.18-xen] fix xenbus_transaction_start()

To: "Laszlo Ersek" <lersek@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH linux-2.6.18-xen] fix xenbus_transaction_start() hang caused by double xenbus_transaction_end()
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Fri, 13 May 2011 09:15:00 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 13 May 2011 01:15:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4DCBB551.7000002@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4DCBB551.7000002@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> On 12.05.11 at 12:24, Laszlo Ersek <lersek@xxxxxxxxxx> wrote:
> fix xenbus_transaction_start() hang caused by double xenbus_transaction_end()
> 
> vbd_resize() up_read()'s xs_state.suspend_mutex twice in a row via double
> xenbus_transaction_end() calls. The next down_read() in
> xenbus_transaction_start() (at eg. the next resize attempt) hangs.
> 
> See RHBZ#618317.
> 
> Thanks for considering.
> 
> Signed-off-by: Laszlo Ersek <lersek@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxxxx>

(I wonder how this ever passed any testing.)

The same would be needed for pv-ops too afaics.

Jan

> ---
>  drivers/xen/blkback/vbd.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/xen/blkback/vbd.c b/drivers/xen/blkback/vbd.c
> --- a/drivers/xen/blkback/vbd.c
> +++ b/drivers/xen/blkback/vbd.c
> @@ -156,6 +156,7 @@
>               goto again;
>       if (err)
>               printk(KERN_WARNING "Error ending transaction");
> +     return;
>  abort:
>       xenbus_transaction_end(xbt, 1);
>  }
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx 
> http://lists.xensource.com/xen-devel 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel