Re: [Xen-devel] [PATCH 1/2, v2] x86: replace nr_irqs sized per-d

To:	Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH 1/2, v2] x86: replace nr_irqs sized per-domain arrays with radix trees
From:	Keir Fraser <keir.xen@xxxxxxxxx>
Date:	Wed, 04 May 2011 20:55:02 +0100
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx, Allen M Kay <allen.m.kay@xxxxxxxxx>
Delivery-date:	Wed, 04 May 2011 12:56:05 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=K6mxDLcaxDpTfo21I0gbqg0K5VeiYA63S1BiNGE4l9g=; b=PrSiCTWmHwnob+Idy17Aje7YMYRvVyb5pxDRfp1uBAGMPVSYHuTxrgVb5PJ0EYc3Jb KYx/A6Y/TUFPH2/FsIZOIZI6jWbseLeKHKXo2o3vKvrkinmNwATFZX7bC5B5f/3BgrCG sWPs8VRLsb3ZhjXS2B8F41YOuGOnxTbIbcguE=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=QzwEyjKIc33Si61QH55SSvq8SCfROH9BrfybiJmGQ/R0p7+HBGluLiEThQyLc+9Oyt dq2XcDEGN+bbRp1V6B3qrl7c18pyIFhFjj8xn//bYVoa4xK55yWHmofQgZiKAT5fFzuq Xgx0WnQQeHR/QpGKxaBRc2RJ9JjKmLMT5P5Hg=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<ae0451ca-f29e-4bed-b594-573dfdd97fd1@default>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcwKlSe8ZV2u+ZRfoUGwKEbo8U7M3A==
Thread-topic:	[Xen-devel] [PATCH 1/2, v2] x86: replace nr_irqs sized per-domain arrays with radix trees
User-agent:	Microsoft-Entourage/12.29.0.110113

On 04/05/2011 17:13, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

> After some offlist discussion, for kztmem (later renamed "the new
> zcache"), I ended up extracting the essence of the radix-tree data
> structure and adapting it inline specifically for my in-kernel tmem
> needs.  While I'm not a fan of duplicating code, this was an
> expedient way to avoid a political quagmire.
> 
> Ideally, the Xen radix-tree.c would support both needs through some
> kind of layering, but if your preference is to go to the upstream
> Linux radix-tree.c, I can probably leverage my inlined-radix-tree
> code into Xen tmem.c.  I don't expect it will be trivial though.

I'm sure I can pull in upstream radix-tree.c and get Xen's tmem ported onto
it. As for performance, I may leave the tagging stuff out as we won't need
it. Then it's just quibbling over RCU overheads, which I would bet are
manageable. We can modify radix-tree.c further if there is good reason for
it.

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH 1/2, v2] x86: replace nr_irqs sized per-domain ar