|  |  | 
  
    |  |  | 
 
  |   |  | 
  
    |  |  | 
  
    |  |  | 
  
    |   xen-devel
[Xen-devel] [PATCH 2/4] mm: Enable set_page_section() only if	CONFIG_SPA 
| To: | ian.campbell@xxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx,	andi.kleen@xxxxxxxxx, haicheng.li@xxxxxxxxxxxxxxx,	fengguang.wu@xxxxxxxxx, jeremy@xxxxxxxx, konrad.wilk@xxxxxxxxxx,	dan.magenheimer@xxxxxxxxxx, v.tolstov@xxxxxxxxx, pasik@xxxxxx,	dave@xxxxxxxxxxxxxxxxxx, wdauchy@xxxxxxxxx, rientjes@xxxxxxxxxx,	xen-devel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,	linux-mm@xxxxxxxxx |  
| Subject: | [Xen-devel] [PATCH 2/4] mm: Enable set_page_section() only if	CONFIG_SPARSEMEM and !CONFIG_SPARSEMEM_VMEMMAP |  
| From: | Daniel Kiper <dkiper@xxxxxxxxxxxx> |  
| Date: | Mon, 2 May 2011 23:20:12 +0200 |  
| Cc: |  |  
| Delivery-date: | Mon, 02 May 2011 14:21:37 -0700 |  
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |  
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |  
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |  
| List-post: | <mailto:xen-devel@lists.xensource.com> |  
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |  
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |  
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |  
| User-agent: | Mutt/1.3.28i |  
| set_page_section() is valid only in CONFIG_SPARSEMEM and
!CONFIG_SPARSEMEM_VMEMMAP context. Move it to proper place
and amend accordingly functions which are using it.
Signed-off-by: Daniel Kiper <dkiper@xxxxxxxxxxxx>
---
 include/linux/mm.h |   14 ++++++++------
 1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 692dbae..23465e1 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -680,6 +680,12 @@ static inline struct zone *page_zone(struct page *page)
 }
 
 #if defined(CONFIG_SPARSEMEM) && !defined(CONFIG_SPARSEMEM_VMEMMAP)
+static inline void set_page_section(struct page *page, unsigned long section)
+{
+       page->flags &= ~(SECTIONS_MASK << SECTIONS_PGSHIFT);
+       page->flags |= (section & SECTIONS_MASK) << SECTIONS_PGSHIFT;
+}
+
 static inline unsigned long page_to_section(struct page *page)
 {
        return (page->flags >> SECTIONS_PGSHIFT) & SECTIONS_MASK;
@@ -698,18 +704,14 @@ static inline void set_page_node(struct page *page, 
unsigned long node)
        page->flags |= (node & NODES_MASK) << NODES_PGSHIFT;
 }
 
-static inline void set_page_section(struct page *page, unsigned long section)
-{
-       page->flags &= ~(SECTIONS_MASK << SECTIONS_PGSHIFT);
-       page->flags |= (section & SECTIONS_MASK) << SECTIONS_PGSHIFT;
-}
-
 static inline void set_page_links(struct page *page, enum zone_type zone,
        unsigned long node, unsigned long pfn)
 {
        set_page_zone(page, zone);
        set_page_node(page, node);
+#if defined(CONFIG_SPARSEMEM) && !defined(CONFIG_SPARSEMEM_VMEMMAP)
        set_page_section(page, pfn_to_section_nr(pfn));
+#endif
 }
 
 /*
-- 
1.5.6.5
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 | 
 
| <Prev in Thread] | Current Thread | [Next in Thread> |  | 
[Xen-devel] [PATCH 2/4] mm: Enable set_page_section() only if	CONFIG_SPARSEMEM and !CONFIG_SPARSEMEM_VMEMMAP,
Daniel Kiper <=
 |  |  | 
  
    |  |  |