|
|
|
|
|
|
|
|
|
|
xen-devel
Re: [Xen-devel] Re: [PATCH][VTD] force boot to fail if interrupt remappi
To: |
Keir Fraser <keir.xen@xxxxxxxxx> |
Subject: |
Re: [Xen-devel] Re: [PATCH][VTD] force boot to fail if interrupt remapping cannot be enabled when iommu=force |
From: |
Joanna Rutkowska <joanna@xxxxxxxxxxxxxxxxxxxxxx> |
Date: |
Thu, 28 Apr 2011 20:26:43 +0200 |
Cc: |
"Cihula, Joseph" <joseph.cihula@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Kay, Allen M" <allen.m.kay@xxxxxxxxx>, Rafal Wojtczuk <rafal@xxxxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx> |
Delivery-date: |
Thu, 28 Apr 2011 11:26:01 -0700 |
Dkim-signature: |
v=1; a=rsa-sha1; c=relaxed/relaxed; d=messagingengine.com; h=message-id:date:from:mime-version:to:cc:subject:references:in-reply-to:content-type; s=smtpout; bh=C3ImJVl6rPjwOvlqBLRNeSCrvEw=; b=S0Xh40MIhSku5f+u6P+WVzjURwvYtWirsBfhHDCobtMCoc5ehUvHYp5brFcngACGaNSKcwsHzExmI7T/Z/1C8g1UlYubPrV5tMcsF9B/ONdD4NRKl1iSMDEaDBd3dIGCY8sUitVizsetI/XUOsGnG6Q604IPThj7kI/KVXl1Ets= |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
In-reply-to: |
<C9DF5CCF.16F23%keir.xen@xxxxxxxxx> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
References: |
<C9DF5CCF.16F23%keir.xen@xxxxxxxxx> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 |
On 04/28/11 19:05, Keir Fraser wrote:
> On 28/04/2011 00:42, "Kay, Allen M" <allen.m.kay@xxxxxxxxx> wrote:
>
>> Force Xen boot to fail if interrupt remapping fails to enable and the
>> following are true: iommu=force is set as xen boot parameter, VT-d engine HW
>> is interrupt remapping capable, DMAR_INTR_REMAP bit is set in DMAR flags.
>> This forces iommu=force boot instances has interrupt remapping enabled if HW
>> and BIOS supports it.
>
> If HW and BIOS support it, why would it fail to be enabled? This doesn't
> look like a particularly useful panic() path. If interrupt remapping is so
> important, perhaps iommu=force should unconditionally require it, and panic
> in its absence regardless of platform features?
Indeed, seems to me like a desired behavior.
j.
> As it is, this looks like a
> panic that is never realistically going to trigger.
>
> -- Keir
>
>> Signed-off-by: Allen Kay <allen.m.kay@xxxxxxxxx>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
signature.asc
Description: OpenPGP digital signature
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
|
|