WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: credit2 BUG_ON triggered

To: George Dunlap <george.dunlap@xxxxxxxxxx>
Subject: Re: [Xen-devel] Re: credit2 BUG_ON triggered
From: John Weekes <lists.xen@xxxxxxxxxxxxxxxxxx>
Date: Tue, 26 Apr 2011 13:15:34 -0700
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>
Delivery-date: Tue, 26 Apr 2011 13:16:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1303837366.1955.21010.camel@elijah>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4DADF781.7070004@xxxxxxxxxxxxxxxxxx> <1303815713.1955.20223.camel@elijah> <4DB6F6AF.7060909@xxxxxxxxxxxxxxxxxx> <1303837366.1955.21010.camel@elijah>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9
On 4/26/2011 10:02 AM, George Dunlap wrote:
OK -- it turns out on my box, I hit the bug as the machine boots, so
repro was very easy. :-)  (Can you tell I haven't been working on
credit2 in a little while?)

Can you test the attached patch and see if it works for you?cc1: warnings being 
treated as errors

On 4.1, it doesn't seem to compile:

sched_credit2.c: In function 'csched_vcpu_migrate':
sched_credit2.c:1363: error: implicit declaration of function 'migrate'
make[4]: *** [sched_credit2.o] Error 1
make[4]: Leaving directory `/usr/src/xen-4.1-testing.hg/xen/common'
make[3]: *** [/usr/src/xen-4.1-testing.hg/xen/common/built_in.o] Error 2
make[3]: Leaving directory `/usr/src/xen-4.1-testing.hg/xen/arch/x86'
make[2]: *** [/usr/src/xen-4.1-testing.hg/xen/xen] Error 2
make[2]: Leaving directory `/usr/src/xen-4.1-testing.hg/xen'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/usr/src/xen-4.1-testing.hg/xen'
make: *** [install-xen] Error 2

I switched back over to -unstable and ran 10 tests:

Test 1: domU freeze after "(XEN) HVMx: Writing SMBIOS tables ..."
Test 2: Seemed to start normally, although VNC didn't work (probably a separate bug in -unstable)
Test 3: domU freeze after "(XEN) HVMx: Writing SMBIOS tables ..."
Test 4: domU freeze after "(XEN) HVMx: Writing SMBIOS tables ..."
Test 5: Seemed to start normally, although VNC didn't work (probably a separate bug in -unstable)
Test 6: domU freeze after "(XEN) HVMx: Writing SMBIOS tables ..."
Test 7: domU freeze after "(XEN) HVMx: Writing SMBIOS tables ..."
Test 8: Seemed to start normally, although VNC didn't work (probably a separate bug in -unstable) Test 9: Seemed to start normally, although VNC didn't work (probably a separate bug in -unstable) Test 10: Seemed to start normally, although VNC didn't work (probably a separate bug in -unstable)

This would seem to confirm that the BUG_ON is being avoided now, but the frequent SMBIOS issue means that I won't be able to start testing credit2 with a subset of customers yet.

Note that when it started normally, there were also tons of "memory.c:196:d18 Bad page free for domain x" and "mm.c:2137:d18 Error pfn 0: rd=ffff8304420d7000, od=ffff830xxxxxxxxxx, caf=8000000000000001, taf=7400000000000001" warnings, which I imagine is a separate concern.

-John

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel