| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH REPOST] pv-grub: Fix for incorrect dom->p2m_host[
|
To: |
Daniel Kiper <dkiper@xxxxxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] [PATCH REPOST] pv-grub: Fix for incorrect dom->p2m_host[] list initialization |
|
From: |
Samuel Thibault <samuel.thibault@xxxxxxxxxxxx> |
|
Date: |
Sat, 23 Apr 2011 00:33:32 +0200 |
|
Cc: |
linux-kernel@xxxxxxxxxxxxxxx, stefano.stabellini@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, konrad.wilk@xxxxxxxxxx |
|
Delivery-date: |
Fri, 22 Apr 2011 15:35:31 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<20110422212545.GA22846@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Mail-followup-to: |
Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, Daniel Kiper <dkiper@xxxxxxxxxxxx>, konrad.wilk@xxxxxxxxxx, stefano.stabellini@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx |
|
References: |
<20110422212545.GA22846@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Mutt/1.5.12-2006-07-14 |
Hello,
Daniel Kiper, le Fri 22 Apr 2011 23:25:45 +0200, a écrit :
> If pfn of newly allocated page is less than currently requested pfn
> then relevant earlier allocated mfn is overwritten which leads to
> domain crash later.
Oops, good catch! And unfortunately it happens seldomly... I guess it
may be the culprit for a fair number of other issues.
> + if (new_pfn < i)
> + for (new_pfn = i; new_pfn < dom->total_pages; ++new_pfn)
> + if (dom->p2m_host[new_pfn] == new_mfn)
> + break;
Instead of looking for the page, which takes a linear time for each page
and thus potentially quadratic time, we should probably rather record
which PFN the MFNs < allocated have been moved to?
Samuel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home