Re: [Xen-devel] use of struct hvm_irq_dpci in pv guests

To:	Jan Beulich <JBeulich@xxxxxxxxxx>
Subject:	Re: [Xen-devel] use of struct hvm_irq_dpci in pv guests
From:	Haitao Shan <maillists.shan@xxxxxxxxx>
Date:	Thu, 21 Apr 2011 15:02:49 +0800
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Thu, 21 Apr 2011 00:03:58 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=EjSBluhZzD/TWaYd4Sf9Dfmk5xW3qwmeAXKBUq7yWR0=; b=sAFhtXpNIEvq+uiz0Dd9C3Ru/Srp5UuWVMNUSHbOM0Ge2Wc5rOtjUWPI9nhgkzwn6N 2TECozss6uof3n9O3ELH0SZHsz/wg9O0vIyQfqGClAJ47D89xj8md9xlEkg2+yPshdWY S1Q4m1i4TmFjIKqztPUb0zHvxthJgO7vdjUlQ=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=LAfdpOaRpcOjHtUhLeg9tfEDnPa1O0r88Rzma4urBtAB2rMomJ4YRL6wAvdI0SsnNe /7oNo0lP2xqKDs3t96OFlcIL1lGTHDdMa3oOLUD9ymuCpI0gBFVn066iy4jN2jZtS1Qz EyTLQJEbDm+dbbHPIVvrmvlExr6Hj13sy+CKU=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<4D94904302000078000395FA@xxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<4D94904302000078000395FA@xxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Hi, Jan,

I think it should be protected by is_hvm_domain(). Anyway, I have saw your patches already in upstream Xen.

Shan Haitao

2011/3/31 Jan Beulich <JBeulich@xxxxxxxxxx>

The per-domain pointer to this is stored in ->arch.hvm_domain.irq.dpci,
hence suggesting that this is a HVM only field.
do_domctl(XEN_DOMCTL_bind_pt_irq) and domain_get_irq_dpci()
access it however without considering HVM-ness. In the course of
splitting/shrinking struct domain, I'd therefore need to know whether
this field ought to become common, or whether all accessors of the
field need to get protected by is_hvm_domain().

Thanks, Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] use of struct hvm_irq_dpci in pv guests