Re: [Xen-devel] [PATCH] tools: hvmloader: attempt to SHUTDOWN_crash on BUG

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[Xen-devel] [PATCH] tools: hvmloader: attempt to 
SHUTDOWN_crash on BUG"):
> tools: hvmloader: attempt to SHUTDOWN_crash on BUG
> 
> If we have got as far as having enabled hypercalls then this signals to the
> toolstack that something went wrong. Otherwise they tend to assume the guest
> has either shutdown or rebooted which can lead to simply trying again
> repeatedly.

Surely in principle this is wrong.  Anything other than a deliberate
decision by hvmloader to exit cleanly (how would that ever happen?)
should be treated as a crash.

Perhaps the toolstack for an hvm domain should set the shutdown reason
to "crashed" before unpausing ?  It looks like this is possible with
an appropriate domctl ...

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel