WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] tool/libxl: mistake apic for acpi in libxl__buil

To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] tool/libxl: mistake apic for acpi in libxl__build_device_model_args_old/new
From: ZhouPeng <zpengxen@xxxxxxxxx>
Date: Tue, 19 Apr 2011 13:14:05 +0800
Cc: "Xen-Devel \(E-mail\)" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 18 Apr 2011 22:14:59 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=kQiLXMgYYfk05p3BcnLbY58gXk6/2LL1PLjCTK9bo0A=; b=pejn+8w8Hc7yjkq0SbVOIxWqOgecUgpngLVHYoz+0PGQhtHuf0lTJkhnB6htlTvT0L mR2eIatw4KnnMqAQjGjbNPARnjasFcxzLgcrkWlTHOlpnBs3pwNXF5M5D9h7rSf990iw nz4KmswQFpEgf3sQrYYCvrpHX8w7AocGI9gIM=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=i6XVpuJ4dLtHVCoa7y04BbpU8PiQtdSwbmwbLf9k3RXnrccm6bQrdqiJCiUDbqMPnN ogPtCavGyonDSdYd8zwost4X1q8mLWqVseTZGsAjs7sbI7ykgjVC5j+WkgCjbIfdjeWb aQq+oac/ub/q3Mv4ax/0hyRpXJTYu+nuKvd5s=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.00.1104181450240.10886@kaball-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <BANLkTikHD2HOYzzV0ci6TBF5=tVSau6zfg@xxxxxxxxxxxxxx> <alpine.DEB.2.00.1104181450240.10886@kaball-desktop>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thanks.

2011/4/18 Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>:
> On Fri, 15 Apr 2011, ZhouPeng wrote:
>> Signed-off-by: Zhou Peng <zhoupeng@xxxxxxxxxxxxxxx>
>>
>> tool/libxl: mistake apic for acpi in libxl__build_device_model_args_old/new
>>
>
> this patch should be applied ASAP and backported to 4.1.
>
>
>> diff -r 6871474a2a09 -r 01f8b29dda8e tools/libxl/libxl_dm.c
>> --- a/tools/libxl/libxl_dm.c    Fri Apr 15 10:06:59 2011 +0800
>> +++ b/tools/libxl/libxl_dm.c    Fri Apr 15 15:17:42 2011 +0800
>> @@ -120,7 +120,7 @@ static char ** libxl__build_device_model
>>          if (info->soundhw) {
>>              flexarray_vappend(dm_args, "-soundhw", info->soundhw, NULL);
>>          }
>> -        if (info->apic) {
>> +        if (info->acpi) {
>>              flexarray_append(dm_args, "-acpi");
>>          }
>>          if (info->vcpus > 1) {
>> @@ -268,7 +268,7 @@ static char ** libxl__build_device_model
>>          if (info->soundhw) {
>>              flexarray_vappend(dm_args, "-soundhw", info->soundhw, NULL);
>>          }
>> -        if (!info->apic) {
>> +        if (!info->acpi) {
>>              flexarray_append(dm_args, "-no-acpi");
>>          }
>>          if (info->vcpus > 1) {
>>
>> --
>> Zhou Peng
>> Operating System Technology Group
>> Institute of Software, the Chinese Academy of Sciences (ISCAS)
>>
>>
>>



-- 
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>