Re: [Xen-devel] [PATCH] libxl: fix against if condition

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

ZhouPeng writes ("[Xen-devel] [PATCH] libxl: fix against if condition"):
> Signed-off-by: Zhou Peng <zhoupeng@xxxxxxxxxxxxxxx>
> 
> --- a/tools/libxl/libxl_dm.c    Wed Apr 13 14:08:41 2011 +0800
> +++ b/tools/libxl/libxl_dm.c    Wed Apr 13 14:20:37 2011 +0800
> @@ -197,7 +197,7 @@ static char ** libxl_build_device_model_
>          int display = 0;
>          const char *listen = "127.0.0.1";
> 
> -        if (info->vncpasswd && info->vncpasswd[0]) {
> +        if (info->vncpasswd && !info->vncpasswd[0]) {
>              assert(!"missing code for supplying vnc password to qemu");
>          }
>          flexarray_append(dm_args, "-vnc");

Looking just at the diff there, I think the original code is correct.
That is, the assert trips when:
  * a password is supplied (info->vncpasswd != NULL)
  * the password is nonemtpy (strlen(info->vncpasswd) > 0
      which is the same as !!info->vncpasswd[0]
  * we're using a new qemu for which this code has not been implemented

That the failure manifests as an assert might be argued to be
unfortunate, but this is still code under development...

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel