 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] x86: don't write_tsc() non-zero values on CPUs u
| To: | Jan Beulich <JBeulich@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] x86: don't write_tsc() non-zero values on CPUs updating only the lower 32 bits |
| From: | Keir Fraser <keir.xen@xxxxxxxxx> |
| Date: | Fri, 15 Apr 2011 08:37:23 +0100 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "winston.l.wang" <winston.l.wang@xxxxxxxxx> |
| Delivery-date: | Fri, 15 Apr 2011 00:39:30 -0700 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=dD1cgR/B1Pk/BOG5Z3NMspJ6NWhGxTHu83kZhpFvhPU=; b=PAQD9BRIMh4EkZnaPOY/rCQZGjM10Nc8iLs8am3+ql1TMytS2aZEa/rhXW3QkivrIJ 7Jkxs7j1ueIAIkRyywo88PSQS74jjPCBan7BL286K4BlmH/W/ZiGbTkW1g3Z0eFgUHgE Umr3uOKnlhFVAeF4aDRCYuxi7XJXhfGngAOAA= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=azclFrQBCw5k5QIoSfeXlrPyWY77Kpb0lD3B9clt0QfgdxbxR35UYzFp3DrvwFSgUb BDwu5lyOYDqeX9FcG2hhz7UvCH+Nli6kqFzTXK4RDAndPXDiyQc0P3ckYOuyB+TL+YCA 4rLohdkyoBdrRxIBy1P6g36MI7d1Xush4K38g= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <4DA80B1A020000780003C875@xxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acv7P/V4gj5nQ7v48USfKIFRAPafkA== |
| Thread-topic: | [Xen-devel] [PATCH] x86: don't write_tsc() non-zero values on CPUs updating only the lower 32 bits |
| User-agent: | Microsoft-Entourage/12.28.0.101117 |
On 15/04/2011 08:08, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote: >> But the write is actually tsc + 4*(s32)(tmp-tsc), and tmp has 1U<<32 ORed >> into it (because it was read after your second write to the TSC. Perhaps we >> should just write back the full original tsc and call that good enough? > > Again, note the (s32) cast. Oh yes. Still the 4x is weird, and on this path (!TSC_RELIABLE, TSC is fully writable) we will sync all AP TSCs as they come up anyway. So writing back the original TSC value is good enough, as far as this matters at all (which it probably doesn't). -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| Previous by Date: | [Xen-devel] [PATCH] xl: refactor common parts of command line parsing, Andre Przywara |
|---|---|
| Next by Date: | [Xen-devel] Re: kernel BUG at arch/x86/xen/mmu.c:1860!, Joerg Stephan |
| Previous by Thread: | Re: [Xen-devel] [PATCH] x86: don't write_tsc() non-zero values on CPUs updating only the lower 32 bits, Jan Beulich |
| Next by Thread: | RE: [Xen-devel] [PATCH] x86: don't write_tsc() non-zero values on CPUs updating only the lower 32 bits, Wang, Winston L |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
