WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86: don't write_tsc() non-zero values on CPUs u

To: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86: don't write_tsc() non-zero values on CPUs updating only the lower 32 bits
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Fri, 15 Apr 2011 07:40:00 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, "winston.l.wang" <winston.l.wang@xxxxxxxxx>
Delivery-date: Thu, 14 Apr 2011 23:40:57 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=iNfCJ+t7WY4TqfPtHXj8WZPirl2NhJA+NW4reimQNnA=; b=QR+/O/nq3Nd2jAhRYdT2l2j7gw7h7lC3iUhvIBgGFgyBrnuSFa037NbsLGJ2S4567o n5jQlB+Ni172VyoSlTTf1NPexhExC/paYs0ZKciLjPY2NHhXzfR1TmihM0DcAd/ACukO 6QuL1zI6U56y8ZHMf4GRw3Z9Lj2hhYGKxJs6Y=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=pPk/IZuixqrpomMGcRb4HYf4Mhyo2V5amXncc3NfE9zHn6Wc3yY0jSBVhjm/k2J16B iApzb5W9w78dtf4JFLgkub3+eZ+31PYvsq9/5lu4XfYGPDRFCcRT4ZnNeAvOnGyR87LW 3MYTpyeW2VsWEcsF7li/sEXgGCb6IrSnz2wnc=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <7a5514b0-b3d6-478a-9434-b80758a7445d@default>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acv7N/FIlU2XI/RwPEmicQ0VEud++A==
Thread-topic: [Xen-devel] [PATCH] x86: don't write_tsc() non-zero values on CPUs updating only the lower 32 bits
User-agent: Microsoft-Entourage/12.28.0.101117
On 14/04/2011 23:41, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

>> Yeah, if we want to continue to try avoiding write_tsc() on
>> TSC_RELIABLE
>> then we should assert !TSC_RELIABLE on the write_tsc() path in
>> cstate_tsc_restore().
> 
> Agreed.  In fact, maybe it should be asserted in write_tsc?

We still write_tsc on CPU physical hot-add.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>