WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] nestedhvm: xentrace support

To: Keir Fraser <keir@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] nestedhvm: xentrace support
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Thu, 14 Apr 2011 16:36:36 +0200
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 14 Apr 2011 07:47:54 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C9CCBC97.2CA58%keir@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C9CCBC97.2CA58%keir@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; NetBSD amd64; en-US; rv:1.9.2.13) Gecko/20110202 Lightning/1.0b3pre Thunderbird/3.1.7
On 04/14/11 16:00, Keir Fraser wrote:
On 13/04/2011 16:34, "Christoph Egger"<Christoph.Egger@xxxxxxx>  wrote:


Tracing facility for nested virtualization

Signed-off-by: Christoph Egger<Christoph.Egger@xxxxxxx>

I fixed this, by adding an extra argument to HVMTRACE_ND() -- it wasn't
really valid to make the first argument be an arbitarry C expression, due to
argument concatenation that then went on in the macro body.

Thanks for your effort.

I also discarded the change to the VMENTRY record to add the guest EIP.
Firstly, it was incomplete, because it did not handle 64-bit RIP. Secondly,
it does not logically belong in this patch. Finally, George may have a
reason for not including RIP in VMENTRY records (e.g., not that useful
compared with the extra space taken up in trace records). So you'd need to
submit a new patch and get an Ack from George (who is currently on holiday).

Ok. If he has one I would like to know it.
For nested virtualization it is at least good debugging information to see if the l2 guest loops somewhere or not.

Christoph


--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>