WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation (cleanup)

To: Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation (cleanup)
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Wed, 13 Apr 2011 14:06:43 +0100
Cc:
Delivery-date: Wed, 13 Apr 2011 06:09:01 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=u1pEPsi4wS2FVoWW+bSj70Qdo/1s3SPg3+L1MI4CYjI=; b=cJ8tphcEvoXoXxvaUcuM8Aa0GpsEAUyAd1ZXrAUeGpvFY1p0lvzpBiJ9tmcsu58gH5 ia7R6BeEby/Dtp7dPhXlujd35iMcUeCBb6cWa11S+YBnlZdpiTzhn0aYBFj0J+XmJsKE wut0Pei3MtzGUdA/7qIvmd1/Yds48Q1LwlN4I=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=oF2DpdlSO5bQ+HPXGZLxF2HfJ2fS+OQDPUlWo0jZFUbjC5JBKvmOCODzcXJt4oNFfp ZQaJ2twCILPR/3hgYNm4wlXfpsYQuIlWuW8Y5lbzFQnmyPhnRuqhr5NEPHL4lLnjAoU8 rcjbA51/nTtCPvx9tXLvjBzlSW59PY9QJPR68=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4DA57C86.7000902@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acv526KFHK77Cf/cRE+0E33kbu9p2A==
Thread-topic: [Xen-devel] [PATCH] nestedhvm: ASID emulation (cleanup)
User-agent: Microsoft-Entourage/12.28.0.101117
On 13/04/2011 11:35, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> Cleanup for ASID emulation:
> - Use C99 integer types for asid numbers

> - asid.c: consistently use 'v' instead of 'curr'

On what planet is that an improvement??

We use 'curr' as a convenient idiom to represent cached current. Whereas 'v'
is supposed to represent an arbitrary vcpu.

I know it costs three extra characters per use, but it does make code easier
to understand.

 -- Keir

> - Introduce svm_invlpga() used in ASID emulation patch
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel