WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2 of 4] x86: make the pv-only e820 array be dynam

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2 of 4] x86: make the pv-only e820 array be dynamic
From: Keir Fraser <keir@xxxxxxx>
Date: Tue, 12 Apr 2011 14:06:05 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Ian.Campbell@xxxxxxxxxx, Tim.Deegan@xxxxxxxxxx
Delivery-date: Tue, 12 Apr 2011 06:08:17 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:user-agent:date:subject:from:to:cc :message-id:thread-topic:thread-index:in-reply-to:mime-version :content-type:content-transfer-encoding; bh=WaOAoCUEp1nlgoKbmKfpzy5oJQb9xeXGIQUUh7Voeic=; b=oKDlPHJcP3U7jO4s5XluLKLrDWWH+RqXGybZ9xq/5/mkwulT2rkqtWHPS84L7rVzey /l92LwpKwasPMw7frPQwokzOmTnWCih4b0N6y6w95enYov9Ysui80pwl1R1iGiyW+SNS sS8I+0q3+65oY0eJEWmVqZ6YYs+xTcG1Weh6Q=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=eFuHOMNVux/wRZMlrLJHxTA/XGHevy8P/CySb7i3cEq7QY5oyEkz+AeBa5lwBGENNH GtQq45sOz9dazAjo/NJPTolTJsdha8qXEzoMd6nTlmHx1jgIN1dRXZdUv9Up+JhZNFQ6 C+VCvkXZQDZZ2iNkc59x18ziA39d1qucO8ggQ=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110412125317.GA19198@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acv5EmF142uLK8B5aEOyIZ8fgTuyyA==
Thread-topic: [Xen-devel] [PATCH 2 of 4] x86: make the pv-only e820 array be dynamic
User-agent: Microsoft-Entourage/12.28.0.101117
On 12/04/2011 13:53, "Konrad Rzeszutek Wilk" <konrad.wilk@xxxxxxxxxx> wrote:

>> How cunning.
>> 
>> Why wouldn't you just allocate exactly the right size of array in
>> XENMEM_set_memory_map?
> 
> I was thinking about it, but the mm.c code did not have the
> xen/xmalloc.h header, nor any references to xmalloc_array.
> 
> Is it OK to make an xmalloc_array during a hypercall?

Yes. I think the toolstack should be able to clean up on the newly-possible
ENOMEM return from this hypercall.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>