WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] remus: fix incorrect error handling for switch_qemu_

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] remus: fix incorrect error handling for switch_qemu_logdirty in checkpoint code
From: Shriram Rajagopalan <rshriram@xxxxxxxxx>
Date: Mon, 11 Apr 2011 10:58:56 -0700
Delivery-date: Mon, 11 Apr 2011 11:00:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mercurial-patchbomb/1.4.3
# HG changeset patch
# User Shriram Rajagopalan <rshriram@xxxxxxxxx>
# Date 1302544427 25200
# Node ID fefe3359ab726e634c00704eadeacfcf30b70c07
# Parent  697ac895c11c6d5d82524de56796cee98fded2a5
remus: fix incorrect error handling for switch_qemu_logdirty in checkpoint code

c/s 22275: "tools: cleanup domain save switch_qemu_logdirty callback"
introduced a whole bunch of error code fixups. In the process, it also ended up
treating the success return code (0) from switch_qemu_logdirty as an error and
vice versa.

Signed-off-by: Shriram Rajagopalan <rshriram@xxxxxxxxx>

diff -r 697ac895c11c -r fefe3359ab72 
tools/python/xen/lowlevel/checkpoint/libcheckpoint.c
--- a/tools/python/xen/lowlevel/checkpoint/libcheckpoint.c      Sat Apr 09 
12:42:24 2011 +0100
+++ b/tools/python/xen/lowlevel/checkpoint/libcheckpoint.c      Mon Apr 11 
10:53:47 2011 -0700
@@ -185,7 +185,7 @@
     hvm = s->domtype > dt_pv;
     if (hvm) {
        flags |= XCFLAGS_HVM;
-       if (!switch_qemu_logdirty(s, 1))
+       if (switch_qemu_logdirty(s, 1))
            return -1;
     }
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] remus: fix incorrect error handling for switch_qemu_logdirty in checkpoint code, Shriram Rajagopalan <=