WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 0 of 7] libxl: refactor tap disk handling

To: Christoph Egger <Christoph.Egger@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0 of 7] libxl: refactor tap disk handling
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Thu, 7 Apr 2011 15:12:23 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 07 Apr 2011 07:13:19 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D9DAEB1.2070407@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <patchbomb.1302169946@xxxxxxxxxxxxxxxxxxxxx> <4D9DAEB1.2070407@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2011-04-07 at 13:31 +0100, Christoph Egger wrote:
> On 04/07/11 11:52, Ian Campbell wrote:
> > I'm not personally convinced that support for blktap2 devices should
> > be conflated in libxl with the PV block backend support but given it's
> > there lets at least correct it.
> >
> > In a blktap2 system there is no "tap" PV backend type. blktap2 exposes
> > a standard block device and this is passed to a guest using the
> > standard blkback "vbd" (sometimes called "phy") backend. Drop the
> > "tap" backend type and associated (libxl internal ) DEVICE_TAP
> > enumeration value.
> 
> What happens on a no-blktap2 system?

Same as before, libxl__blktap_enabled still returns false and the same
things should happen as a result.

Ian.
> 
> >
> > Also try and clarify the paths which fallback from blktap2 to qdisk
> > when the former is not present. Falling through a switch statement is
> > a neat way of doing this in some cases, but I don't think this is one
> > of them.
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > http://lists.xensource.com/xen-devel
> >
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel