| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [PATCH] xen: netfront: fix declaration order
|
To: |
Eric Dumazet <eric.dumazet@xxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH] xen: netfront: fix declaration order |
|
From: |
Michał Mirosław <mirq-linux@xxxxxxxxxxxx> |
|
Date: |
Sun, 3 Apr 2011 19:35:26 +0200 |
|
Cc: |
jeremy.fitzhardinge@xxxxxxxxxx, Ian.Campbell@xxxxxxxxxx, konrad.wilk@xxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, David Miller <davem@xxxxxxxxxxxxx> |
|
Delivery-date: |
Wed, 06 Apr 2011 18:33:00 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<1301828839.2837.143.camel@edumazet-laptop> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20110331110136.03A1A13A6A@xxxxxxxxxxxx> <20110401.205455.70198735.davem@xxxxxxxxxxxxx> <1301828839.2837.143.camel@edumazet-laptop> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Sun, Apr 03, 2011 at 01:07:19PM +0200, Eric Dumazet wrote:
> Le vendredi 01 avril 2011 à 20:54 -0700, David Miller a écrit :
> > From: Michał Mirosław <mirq-linux@xxxxxxxxxxxx>
> > Date: Thu, 31 Mar 2011 13:01:35 +0200 (CEST)
> >
> > > Not tested in any way. The original code for offload setting seems broken
> > > as it resets the features on every netback reconnect.
> > >
> > > This will set GSO_ROBUST at device creation time (earlier than connect
> > > time).
> > >
> > > RX checksum offload is forced on - so advertise as it is.
> > >
> > > Signed-off-by: Michał Mirosław <mirq-linux@xxxxxxxxxxxx>
> > Applied.
> Hmm... I had to apply following patch to make it actually compile.
> [PATCH] xen: netfront: fix declaration order
>
> Must declare xennet_fix_features() and xennet_set_features() before
> using them.
Hmm. Sorry for that. Looks like x86 allyesconfig doesn't include this
driver in the build. :/
There really needs to be something like CONFIG_LINT...
Best Regards,
Michał Mirosław
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home