WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: preempt_disable() imbalance in take_machine_down()? [lin

To: "Laszlo Ersek" <lersek@xxxxxxxxxx>
Subject: [Xen-devel] Re: preempt_disable() imbalance in take_machine_down()? [linux-2.6.18-xen.hg]
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Tue, 05 Apr 2011 15:18:26 +0100
Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>, Drew Jones <drjones@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 05 Apr 2011 07:18:21 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D9B2031.5080100@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4D9B2031.5080100@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> On 05.04.11 at 15:59, Laszlo Ersek <lersek@xxxxxxxxxx> wrote:
> Looking at take_machine_down() and __xen_suspend() in 
> "drivers/xen/core/machine_reboot.c", assuming "fast_suspend" is false, 
> it seems that after the loop in take_machine_down() completes, 
> preempt_enable() is never called. Is this intentional?

Probably not.

> If so, how/why does it work?

Because PREEMPT depends on !XEN in kernel/Kconfig.preempt.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>